Forgotten commit: test coverage and cleanup

papi/config.py

@@ -4,6 +4,7 @@ import glob
 import configparser
 
 import logging as logger
+from papi.sqlapp import crud
 
 
 def read_config(*, kind=None, pattern="*"):
@@ -37,7 +38,7 @@ def read_config(*, kind=None, pattern="*"):
         gg = dict(conf["relais"])
         for k, v in gg.items():
             gg[k] = v.strip()
-            if "'" in v or '"' in v:
+            if "'" in v or '"' in v:  #
                 raise ValueError(
                     f"{k}:{v} from {path} containts forbidden char (escaping issue)"
                 )

papi/mail_sendermodel.py

@@ -21,7 +21,6 @@ def sendmail(htmlpart, emails, textpart="", subject="Monitorig api"):
         ]
     }
     if nomail:
-        breakpoint()
         print(data)
         return
     result = mailjet.send.create(data=data)

papi/main.py

@@ -184,9 +184,6 @@ def last_notif_text(request: Request, idsonde: str, db: Session = Depends(get_db
     try:
         recipients = sondeid2notifsemails(idsonde)
     except KeyError:  # pragma: no cover
-
-        # breakpoint()
-
         recipients = ["mail1@xxx", "mail2@xxx", f"{idsonde}@fqdn"]
 
     changements = content["changes"]

papi/relais.py

@@ -1,11 +1,9 @@
 import requests
 import urllib3
-import sys
-from .config import read_config
 import logging as logger
-import json
 import math
 import itertools
+from . import config
 
 https = False
 

tests/test_config.py

@@ -1,5 +1,6 @@
 from unittest import TestCase
 from papi import main
+import pytest
 
 
 class ConfigurationTestCase(TestCase):
@@ -21,3 +22,17 @@ class ConfigurationTestCase(TestCase):
         assert config["emails"] == [
             "1@1",
         ]
+
+    def test_cover_raise(self):
+        with pytest.raises(ValueError) as exc:
+            configs = main.read_config(kind="relais", pattern="relais_code_test_sonde")
+
+    def test_duplicate_exists_in_db(self):
+        # donw wth coverage
+        from papi.main import atomic_db
+
+        configs = main.read_config(pattern="*1mail")
+        assert len(configs) == 1
+        dups = [configs[0], configs[0]]
+        #breakpoint()
+        main.apply_config(atomic_db=atomic_db, configs=dups)